Re: Net::LDAP class
| From: | Alan Knowles | Date: | Thu, 24 Jul 2003 02:23:34 +0000 |
| Subject: | Re: Net::LDAP class | ||
| References: | 1 2 3 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-18610@lists.php.net to get a copy of this message | ||
In principle +1 on this, however it needs alot of tidying up :)
- phpdoc comments
- replace 'short' variables with more descriptive ones eg. $_
- CS indentation, bracket placement, method names, control structures without {},
- class names: Net_Ldap, Net_Ldap_Entry, Net_Ldap_Result
- I saw one place where '_set_serach()' (eg. a quasi private) was called externally.
- odd code bits:
"$v";
rather than just $v
"unknown host" . $this->_['host'] . " " . "$conn"
rather than
"unknown host {$this->_['host']} {$conn}"
ldap_entry would be nice with overload('Net_Ldap_Entry')
function __get($prop,&$ret) {
$ret = $this->attributes[$prop];
}
function __set($prop,$val,&$ret) {
$this->attributes[$prop] = $val;
}
Regards
Alan
Tarjei Huse wrote:
Hi, The source can now be found here: http://cms.polarmedia.no/midgard/php-ldap/ The ldap.php[s] file is a set of examples that should show usage. The other one is a file containing all the classes. I know it's not completly pear complient yet, but your comments and suggestions would help :-) Tarjei On Wed, 2003-07-23 at 03:08, Alan Knowles wrote:-- Can you help out? Need Consulting Services or Know of a Job? http://www.akbkhome.comCan you the source online? - give us an idea of what it does? Regards Alan Tarjei Huse wrote:Hi, I've written a PHP implementation of Perls Net::LDAP class as I found it much easier to use than the DB::Ldap class (and is is documented). Would you guys be interested in adding it to Pear? Tarjei Mob: 920 63 413-- Can you help out? Need Consulting Services or Know of a Job? http://www.akbkhome.com