Re: [Patch] for Mail_mimeDecode
| From: | Heino H. Gehlsen | Date: | Sun, 27 Jul 2003 15:18:39 +0000 |
| Subject: | Re: [Patch] for Mail_mimeDecode | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-18799@lists.php.net to get a copy of this message | ||
> I am interested in the patch because I use the set of packages:
> Mail_mimeDecode
> NNTP
> Config
> Console_Getopts
Wouldn't you then agree that the uudecode() function and the header parsing
functions ought to be moved from Meil_mimeDecode into some separate
'encoding/decoding' class and a 'headers' class which could then be used by
Net_NNTP, Net_IMAP and Mail_Mime. Although I CC'ed my mail "Package
proposal: Mail_RFC822_Headers" to the developers of the listed packages, I
only got two quick comments, so I made my own Net_NNTP_Headers class for
now...
Personally I find it problematic, that Mail_mimeDecode doesn't allow one to
set the headers and body separately (whitch can now only be done by using
the private variables $_header and $_body, and that's cheating), and in my
honest opinion, it's waste of flops when you have to implode a perfectly
sorted array containing headers into a string just to let decode()
re-explode the string and redo a almost identical array of headers - one
should be allowed to bypass the header parsing part by giving af array of
headers...
> I didn't test your .3 version yet but I am very curious about it...
> (very busy with other stuff)
The skip it, and do th .5 in its stead. (attached)
I honestly no longer remember what has changed - some improvements i guess
;-)
(Hope those cvs access granting people will let me in soon - a lot of the
changes should have been commited a long time ago)
Heino
Attachment: [application/x-compressed] Net_NNTP-0.2.999.5.tgz
Attachment: [application/x-compressed] Net_NNTP-0.2.999.5.tgz