Re: HTML_SetupWizard and more ....
| From: | Lorenzo Alberton | Date: | Thu, 31 Jul 2003 09:22:40 +0000 |
| Subject: | Re: HTML_SetupWizard and more .... | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-19014@lists.php.net to get a copy of this message | ||
On Thu, 31 Jul 2003 00:18:46 +0200, Laurent Laville wrote:
> In past i've tried to present a proposal package called
> HTML_SetupWizard.
I finally had the time to have a look at this package.
I must say it's amazing, the amount of documentation
produced should be an example for us all.
I'm +1 on having this in PEAR.
Just a few considerations:
- what about other template engines? Can we switch
to the one we like (I haven't checked the sources
about this subject)? Is template-management detached
from the main class? A template "plugin" model would be great.
- In the examples provided, the main index.php has a
few NOTICES:
"${node1_ .$i}" should be "${'node1_'.$i}" (notice the quotes).
Similarly for ${nodeX .$i}
- in function registerElementWizard, you should use the
DIRECTORY_SEPARATOR constant instead of hard-coding a '/':
$dir = dirname(__FILE__) .
DIRECTORY_SEPARATOR.'SetupWizard'.DIRECTORY_SEPARATOR.'GUI';
and a few lines below:
$file = $dir.DIRECTORY_SEPARATOR.$entry;
Best regards,
Lorenzo