#19114 [Csd]: Typo in buildManipSQL function in DB/common.php

ID: 19114 Updated by: arnaud@php.net Reported By: bugs at pointb dot co dot uk Status: Closed Bug Type: PEAR related Operating System: RedHat Linux 7.3 PHP Version: 4.2.2 New Comment: i belive this will make it into 4.3.3 Previous Comments: ------------------------------------------------------------------------ [2003-07-31 04:49:37] jon at latchkey dot com It kind of sucks that this bug is *still* being distributed with PHP 4.3.2! I just got bit by it pretty badly. Please update common.php with the distribution! ------------------------------------------------------------------------ [2002-08-26 16:25:43] fab@php.net This bug has been fixed in CVS. In case this was a PHP problem, snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. In case this was a documentation problem, the fix will show up soon at http://www.php.net/manual/. In case this was a PHP.net website problem, the change will show up on the PHP.net site and on the mirror sites in short time. Thank you for the report, and for helping us make PHP better. Of course ! It\'s fixed in CVS : -Fix bug in buildManipSQL (thanks KUBO Atsuhiro <kubo@isite.co.jp>) Thanks :-) ------------------------------------------------------------------------ [2002-08-26 16:15:21] bugs at pointb dot co dot uk I am using version 1.3 of the Database Abstraction Layer. There is the following section in the buildManipSQL function in the DB/common.php file that I think may have a typo in it: The section is as follows: if ($where) { $sql .= " WHERE $sql"; } and I think it should be: if ($where) { $sql .= " WHERE $where"; } ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=19114&edit=1