Re: Proposal: XML_Util
| From: | Martin Jansen | Date: | Thu, 31 Jul 2003 20:44:42 +0000 |
| Subject: | Re: Proposal: XML_Util | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-19087@lists.php.net to get a copy of this message | ||
On Thu Jul 31, 2003 at 10:2640PM +0200, Stephan Schmidt wrote:
> The source is available at:
> http://www.php-tools.de/PEAR/XML_Util/XML_Util.phps
Why do you derive XML_Util from PEAR? That's absolutely not needed.
Apart from that there are some CS issues left:
* NULL should be null
* function replaceEntities( $string ) should be
function replaceEntities($string)
* if ($encoding!==NULL) { should be
if ($encoding !== null) {
I'm +1 for this as long as there will be documentation in plain text or
Docbook available. Otherwise I'm -1. (XML_Util sounds fine for me, btw.)
--
- Martin Martin Jansen
http://martinjansen.com/