#24920 [NEW]: <license> in changelog overwrites license in getInfoFromString()

From: greg at chiaraquartet dot net Operating system: na PHP version: 4.3.2 PHP Bug Type: PEAR related Bug description: <license> in changelog overwrites license in getInfoFromString() Description: ------------ if the last changelog entry has a <license> entry that differs from the release license, PEAR_Common->getInfoFromString() will return the license as the changelog entry rather than the current release license. Either the DTD should be updated to reflect the validation in PEAR_Common, or PEAR_Common should use this patch to retrieve the license tag in the changelog: Index: pear/PEAR/Common.php =================================================================== RCS file: /repository/php-src/pear/PEAR/Common.php,v retrieving revision 1.93 diff -u -r1.93 Common.php --- pear/PEAR/Common.php 12 Jul 2003 15:15:38 -0000 1.93 +++ pear/PEAR/Common.php 2 Aug 2003 18:12:54 -0000 @@ -567,7 +578,11 @@ } break; case 'license': - $this->pkginfo['release_license'] = $data; + if ($this->in_changelog) { + $this->current_release['release_license'] = $data; + } else { + $this->pkginfo['release_license'] = $data; + } break; case 'dep': if ($data && !$this->in_changelog) { -- Edit bug report at http://bugs.php.net/?id=24920&edit=1 -- Try a CVS snapshot (php4): http://bugs.php.net/fix.php?id=24920&r=trysnapshot4 Try a CVS snapshot (php5): http://bugs.php.net/fix.php?id=24920&r=trysnapshot5 Fixed in CVS: http://bugs.php.net/fix.php?id=24920&r=fixedcvs Fixed in release: http://bugs.php.net/fix.php?id=24920&r=alreadyfixed Need backtrace: http://bugs.php.net/fix.php?id=24920&r=needtrace Try newer version: http://bugs.php.net/fix.php?id=24920&r=oldversion Not developer issue: http://bugs.php.net/fix.php?id=24920&r=support Expected behavior: http://bugs.php.net/fix.php?id=24920&r=notwrong Not enough info: http://bugs.php.net/fix.php?id=24920&r=notenoughinfo Submitted twice: http://bugs.php.net/fix.php?id=24920&r=submittedtwice register_globals: http://bugs.php.net/fix.php?id=24920&r=globals PHP 3 support discontinued: http://bugs.php.net/fix.php?id=24920&r=php3 Daylight Savings: http://bugs.php.net/fix.php?id=24920&r=dst IIS Stability: http://bugs.php.net/fix.php?id=24920&r=isapi Install GNU Sed: http://bugs.php.net/fix.php?id=24920&r=gnused