RE: [PEAR-DEV] Net_ldap 0.1
| From: | LIMBOURG Arnaud | Date: | Wed, 06 Aug 2003 09:48:14 +0000 |
| Subject: | RE: [PEAR-DEV] Net_ldap 0.1 | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-19321@lists.php.net to get a copy of this message | ||
one thing escaped me
function start_tls()
is not CS compliant, it should be
function startTls()
or something like that, underscores (_) are not CS compliant in method
names. They are ok in class names, hence Net_LDAP with constructor having
the same name.
Arnaud.
> Ok, seeing people wanted to get this into CVS I've done more
> changes and
> uploaded them to the normal place (this time w/o phps files around).
>
> See: http://cms.polarmedia.no/midgard/Net_LDAP/
>
> Changelog:
>
> * Edward Rudds compliance patch
> * Arnaud Limbourgs cleanups of LDAP.php
> * After reading the comments I tried to clean up all the comments +
> whitespaceissues in LDAP/Entry.php and LDAP/Search.php.
> * Also after Arnauds comments, LDAP::connect() now retunrs a reference
> to an object.
>
> Thanks all!