Re: #21845 [Asn]: $this in static calls

Hi, I'd like to request officially to be included in the list of developers who are authorized to fix bugs in the core of PEAR. I have studied it intensively, and really do know it inside and out at this point. Critical bugs like the one below need to be committed sooner, and there aren't enough people who have time to do this. I can test bugs on Windows and Linux. I am also committed to designing unit tests that can be used to verify that bugfixes indeed fix bugs for every bug I fix, and that future changes don't re-break them. I don't have this motivation if I am only submitting patches. I would not use this permission to commit anything that adds new functionality without explicit approval from all three of you. I also will not roll new releases or do any other fancy stuff, as I have no experience with that kind of thing. Thanks, Greg cellog@php.net wrote:

 ID:               21845
 Updated by:       cellog@php.net
 Reported By:      cynic@php.net
 Status:           Assigned
 Bug Type:         PEAR related

Operating System: na

 PHP Version:      4.3.2
 Assigned To:      cox

New Comment: This bug renders setErrorHandling() useless inside a class that doesn't extend PEAR, and is therefore kind of important. I'd like to commit the patch I posted previously for 4.3.3's release. All it does is change the test of if (isset($this)) to if (isset($this) && (get_class($this) == 'pear' || is_subclass_of($this, 'pear'))), ensuring correct behavior (the static handling should be used in a class that is not a PEAR descendant) Greg Previous Comments: ------------------------------------------------------------------------ [2003-07-31 15:28:02] cellog@php.net There are a few other functions that need a similar patch. If it looks good, I'm happy to commit this patch. Greg Index: pear/PEAR.php =================================================================== RCS file: /repository/php-src/pear/PEAR.php,v retrieving revision 1.65 diff -u -r1.65 PEAR.php --- pear/PEAR.php 10 Jul 2003 11:35:37 -0000 1.65 +++ pear/PEAR.php 31 Jul 2003 20:25:56 -0000 @@ -289,7 +289,8 @@

     function setErrorHandling($mode = null, $options = null)
     {
-        if (isset($this)) {
+        if (isset($this) &&
+            (get_class($this) == 'pear' || is_subclass_of($this,

'pear'))) {

             $setmode     = &$this->_default_error_mode;
             $setoptions  = &$this->_default_error_options;
         } else {

@@ -566,7 +567,8 @@

     function pushErrorHandling($mode, $options = null)
     {
         $stack = &$GLOBALS['_PEAR_error_handler_stack'];
-        if (isset($this)) {
+        if (isset($this) &&
+            (get_class($this) == 'pear' || is_subclass_of($this,

'pear'))) {

             $def_mode    = &$this->_default_error_mode;
             $def_options = &$this->_default_error_options;
         } else {

@@ -575,7 +577,8 @@

         }
         $stack[] = array($def_mode, $def_options);
 -        if (isset($this)) {
+        if (isset($this) &&
+            (get_class($this) == 'pear' || is_subclass_of($this,

'pear'))) {

             $this->setErrorHandling($mode, $options);
         } else {
             PEAR::setErrorHandling($mode, $options);

@@ -600,7 +603,8 @@

         array_pop($stack);
         list($mode, $options) = $stack[sizeof($stack) - 1];
         array_pop($stack);
-        if (isset($this)) {
+        if (isset($this) &&
+            (get_class($this) == 'pear' || is_subclass_of($this,

'pear'))) {

             $this->setErrorHandling($mode, $options);
         } else {
             PEAR::setErrorHandling($mode, $options);

------------------------------------------------------------------------ [2003-03-13 15:29:12] mj@php.net throwError() has been patched for now. ------------------------------------------------------------------------ [2003-03-13 15:23:29] cynic@php.net *what* was fixed? was the $this transfer fixed, or was PEAR_Error::throwError() patched to work around it? ------------------------------------------------------------------------ [2003-03-13 15:10:47] mj@php.net This bug has been fixed in CVS. In case this was a PHP problem, snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. In case this was a documentation problem, the fix will show up soon at http://www.php.net/manual/. In case this was a PHP.net website problem, the change will show up on the PHP.net site and on the mirror sites in short time. Thank you for the report, and for helping us make PHP better. ------------------------------------------------------------------------ [2003-03-08 09:14:08] alan_k@php.net I think Andi confirmed this behaviour will disappear in PHP5 (the $this transfer on static methods), Probably worth emailing Stig or pear-dev to confirm that nobody has a problem with this (patch looks ok to me) ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at

    http://bugs.php.net/21845