Re: File_Vorbis Latest...

Hi Stefan, On 2003.08.12 23:48, Stefan Neufeind wrote:

I wouldn't call myself "too experienced" with pear yet. But if you might be interested in my 2 cents anyway:

Of course! All feedback is more than welcome.

Refering to http://www.vorbis.com/faq.psp#names "Ogg is the name of Xiph.org's container format for audio, video, and metadata.". So wouldn't, refering to meta-data, it be a File_Ogg-package? But since we're also talking about Vorbis-specific details (e.g. Bitrates) okay. Just thought off Ogg Theora or even Speex which also use an Ogg container. Wouldn't abstracting a general ogg-part for meta-data make sense? If you have a look at the ogginfo-output it says that there was a "vorbis stream" found. Maybe think of multichannel-audio (English/German/...) or audio/video and similar. Then having a File_Ogg to handle all streams inside the file would make sense.

You raise some interesting points. Should a File_Ogg base class be established for Ogg metadata, with extension down to the individual implementing classes, such as File_Ogg_Vorbis? While this will reduce unnecessary functionality for single-stream files, it may make implementing multi-stream files more cumbersome.

Back to your File_Vorbis: Would it be possible to also display the length or the stream and maybe the "total data length" (see ogg info) for that stream? Looking at the source without going into too much technical detail looks fine for me. Didn't find a necessity to criticise anything.

Absolutely. File_Vorbis is currently missing a few features (i.e. all those missing from ogginfo). This is not a release version, just a RFC. Regards, David