Re: New package: DB_DataObject_FormBuilder
| From: | Markus Wolff | Date: | Sun, 24 Aug 2003 14:21:37 +0000 |
| Subject: | Re: New package: DB_DataObject_FormBuilder | ||
| References: | 1 2 3 4 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-20454@lists.php.net to get a copy of this message | ||
Ron McClain wrote:
Hi Markus. Finally got some time to look at this. It looks really nice.. been meaning to write it myself ;) Anyhow, I think you have a bug. Shouldn't the elseif condition be is_array? Otherwise, the package looks great. I know I'll make use of it. Just thought I'd point that out.Hi Ron, glad you like it ;-) The thing you´ve spotted is not actually a bug, but a piece of currently unused code. In theory, _array2date() doesn´t only convert date-arrays to strings, but also Unix timestamps (hence the second parameter). So you could pass a Unix timestamp to the method and get an ISO-formatted date string back. I wrote this some time ago and - for some reason unknown to me at this point - thought it might be useful one day. Right now, I think what I´ve written there is a piece of crap ;-) As I will need much better DATETIME support in the near future, I expect these lines to be thrown out in the process ;-) Thanks for reporting, anyway! CU Markus