[PATCH] inline documentation, few bug fixes for XML_RPC

From: Date: Mon, 25 Aug 2003 06:14:45 +0000
Subject: [PATCH] inline documentation, few bug fixes for XML_RPC
Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-20479@lists.php.net to get a copy of this message
It seems to be a busy night for patches! Hopefully, the people with CVS access won't be too bogged down. :-) It's going to take a while for me to finish all that I want to do with XML_RPC in terms of "cleaning up" the globals, etc. Here's what I've done so far that should help a little: 1. Added inline documentation to almost all functions. A lot of this came directly from Useful Inc's documentation. (Should I generate the peardoc XML, or does someone in charge of documentation do that?) 2. Moved XML_RPC_Client to RPC/Client.php. It makes more sense to me that way, since XML_RPC_Server is in RPC/Server.php. For BC, I include_once'd RPC/Client.php into RPC.php, but that should be removed eventually. 3. Added support for sequential arrays to XML_RPC_encode(). This came from PEAR/Remote.php. 4. Fixed lots of very minor PEAR coding standards violations, including missing spaces on either side of operators. What can I say, I'm nit-picky! 5. Fixed bug #25228, regarding a "-503 Unclosed Token" error. All this required was a case change in the "Content-Length" header. Attached is Client.php and a diff for the rest of the files, including package.xml. It's rather long, but most of it is documentation. -- Marshall Roch

« previous php.pear.dev (#20479) next »