Re: Net_ICQ...and pear talks OSCAR

From: Date: Thu, 28 Aug 2003 15:56:23 +0000
Subject: Re: Net_ICQ...and pear talks OSCAR
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-20759@lists.php.net to get a copy of this message
> I can see the incoming and outgoing subclasses, but do you really need > separate files for constant definitions and common functions? File > inclusion is relatively expensive on most systems, so it'd be nice to > consolidate a bit. The point is that each class is used to parse or create a lot of data and so it would be too much code for one file... I am currently implementing the Net_ICQ_func class to extend the main Net_ICQ class. I've done these seperations because it's much more understandable this way. I moved the constant definitions back to ICQ.php. > It would be nice if the classnames matched the filenames. I'd say make > the class names more verbose, instead of shortening the filenames Ok, done. > Also, examples/examples.php should be something clearer, like > examples/bot.php. Done.

« previous php.pear.dev (#20759) next »