#25008 [Asn->Csd]: unhelpful Installer Error Message

ID: 25008 Updated by: cellog@php.net Reported By: cellog@php.net -Status: Assigned +Status: Closed Bug Type: PEAR related Operating System: na -PHP Version: 4.3.3RC3 +PHP Version: 4.3.3 -Assigned To: cox +Assigned To: cellog New Comment: This bug has been fixed in CVS. In case this was a PHP problem, snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. In case this was a documentation problem, the fix will show up soon at http://www.php.net/manual/. In case this was a PHP.net website problem, the change will show up on the PHP.net site and on the mirror sites in short time. Thank you for the report, and for helping us make PHP better. Previous Comments: ------------------------------------------------------------------------ [2003-08-10 19:33:19] cellog@php.net Description: ------------ if you try to install a package from a package.xml, and a file is listed in the package.xml that doesn't exist, the error message is not helpful. This patch changes the error message to let you know what happened Index: pear/PEAR/Installer.php =================================================================== RCS file: /repository/php-src/pear/PEAR/Installer.php,v retrieving revision 1.93 diff -u -r1.93 Installer.php --- pear/PEAR/Installer.php 4 Aug 2003 13:31:35 -0000 1.93 +++ pear/PEAR/Installer.php 11 Aug 2003 00:29:45 -0000 @@ -222,6 +222,10 @@ $this->log(3, "+ mkdir $dest_dir"); } if (empty($atts['replacements'])) { + if (!file_exists($orig_file)) { + return $this->raiseError("file does not exist", + PEAR_INSTALLER_FAILED); + } if (!@copy($orig_file, $dest_file)) { return $this->raiseError("failed to write $dest_file", PEAR_INSTALLER_FAILED); @@ -231,6 +235,10 @@ $md5sum = md5_file($dest_file); } } else { + if (!file_exists($orig_file)) { + return $this->raiseError("file does not exist", + PEAR_INSTALLER_FAILED); + } $fp = fopen($orig_file, "r"); $contents = fread($fp, filesize($orig_file)); fclose($fp); @@ -695,6 +703,9 @@ if (PEAR::isError($res)) { if (empty($options['ignore-errors'])) { $this->rollbackFileTransaction(); + if ($res->getMessage() == "file does not exist") { + $this->raiseError("file $file in package.xml does not exist"); + } return $this->raiseError($res); } else { $this->log(0, "Warning: " . $res->getMessage()); Expected result: ---------------- file XXX in package.xml does not exist Actual result: -------------- failed to write /temppath/.tmpXXX ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=25008&edit=1