Re: Preliminary Proposal for calculator for suntimes / moontimes

Jon Parise <jon@php.net> escribió > On Wed, Aug 27, 2003 at 11:08:11AM +0200, Alexander Wirtz wrote: > > > while working on the weather-class, I wrote two other classes, at the > > moment called Date_Sun and Date_Moon > > http://www.pc4p.net/downloads/Sun.phps > > http://www.pc4p.net/downloads/Moon.phps > > > > The problem now is, how to call the package as a whole? Pierre suggested > > to include them directly in Date, but I'm not convinced, that this is a > > good idea, I would like to keep them seperate. > > I'm well aware, that PHP5 has implemented suntime-functions, so my > > suggestion is, to keep two different packages Date_Sun and -_Moon, so > > that it is easier to trash Sun afterwards. That means maintaining two > > packages, but that's ok with me. That looks really cool, +1 > I would like to see them added to the existing Date package or > released as a separate Date_SunMoon package. I think it should be a separate package, not part of Date. The date of sunset/sunrise is a property of a given location (Location object?), not of a given date. And on a more practical side, it doesn't (have to) share any code with Date anyways. Xavier