Re: [Call for Votes] XML_Statistics

Hi Stephan OK, I've looked over the code a little, and tried all the examples. Here are my comments: * CS: - Private class members must be prefixed with _ * Examples need to be fixed: - for the include: 'XML/Statistics.php' - example file input: 'example.xml' - put \n after each <br> to help when looking at the source or running from the command line. And so on. - Comment the examples so people know what everything does - example3.php needs to mention that it requires the Math_Stats package All in all, it's a very useful package. Review: Cursory review of code, all examples tested Vote: +1 Account: thesaur Klaus ----- Original Message ----- From: "Stephan Schmidt" <s.schmidt@metrix.de> To: "Klaus Guenther" <klaus@capitalfocus.org>; "'pear-dev'" <pear-dev@lists.php.net> Sent: Tuesday, September 09, 2003 11:26 AM Subject: AW: [PEAR-DEV] [Call for Votes] XML_Statistics > Hi, > > sorry, the package file is located at: > > > http://www.php-tools.de/PEAR/XML_Statistics/XML_Statistics-0.1.tgz > > Wrong version number in the href attribute :-( > > Stephan > > > -----Ursprüngliche Nachricht----- > > Von: Klaus Guenther [mailto:klaus@capitalfocus.org] > > Gesendet: Dienstag, 9. September 2003 11:14 > > An: schst@php-tools.net; 'pear-dev' > > Betreff: Re: [PEAR-DEV] [Call for Votes] XML_Statistics > > > > > > Hi Stephan, > > > > You have a broken link: > > > > http://www.php-tools.de/PEAR/XML_Statistics/XML_Statistics-0.9.tgz > > > > From what I've seen, it looks very useful. I'm working on a > > project where I > > could use it right away. > > > > Once I've tested it, you'll get my vote :-) > > > > Klaus > > > > ----- Original Message ----- > > From: "Stephan Schmidt" <schst@php-tools.net> > > To: "'pear-dev'" <pear-dev@lists.php.net> > > Sent: Tuesday, September 09, 2003 8:35 AM > > Subject: [PEAR-DEV] [Call for Votes] XML_Statistics > > > > > > > Hi, > > > > > > Last week I sent a request for comments on a new package, which I dubbed > > > XML_Statistics. There has been no real discussion, but already three > > > approvals. To follow the new rules, I'd now like to enter the next stage > > > and officially call for votes on the package. > > > > > > A brief description, sourcecode, examples and a downloadable package > > > file can be found at: > > > > > > http://www.php-tools.de/PEAR/XML_Statistics/ > > > > > > So now give me your +1' (or -1's of course). > > > > > > Stephan > > > > > > -- > > > PEAR Development Mailing List (http://pear.php.net/) > > > To unsubscribe, visit: http://www.php.net/unsub.php > > > > > > > > > > > > -- > PEAR Development Mailing List (http://pear.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > >