RE: [PEAR-CVS] cvs: pear /MDB/MDB ibase.php
| From: | Lorenzo Alberton | Date: | Thu, 25 Sep 2003 07:58:35 +0000 |
| Subject: | RE: [PEAR-CVS] cvs: pear /MDB/MDB ibase.php | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-21970@lists.php.net to get a copy of this message | ||
On Thu, 25 Sep 2003 09:12:14 +0200, Lukas Smith wrote:
>> quipo Wed Sep 24 19:49:07 2003 EDT
>> @@ -995,9 +995,9 @@
>> if (!is_array($row)) {
>> return null;
>> }
>> - foreach ($row as $key => $value_with_space) {
>> - $row[$key] = rtrim($value_with_space); - }
>> + }
>> + foreach ($row as $key => $value_with_space) {
>> + $row[$key] = rtrim($value_with_space); }
>> if (isset($this->results[$result_value]['types'])) { $row = $this-
>> >datatype->convertResultRow($result, $row);
>
> Actually this should stay where it was.
> All rows there are pulled from the row buffer already have rtrim
> applied before they were put in the buffer.
well, it seems it doesn't happen every time.
That's why I moved those three lines one level up,
to guarantee rtrim() is applied (...at least once!).
Anyway, no big deal here. The worst thing can happen
is rtrim() being applied twice, which can't hurt :-)
> However I found another issue and here is a CVS diff:
committed, thanks.
---
Lorenzo