Re: package proposal: Games_Chess
| From: | Greg Beaver | Date: | Wed, 08 Oct 2003 12:52:41 +0000 |
| Subject: | Re: package proposal: Games_Chess | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-22473@lists.php.net to get a copy of this message | ||
Stefan Neufeind wrote:
Fully agreed! After having played a bit I'm impressed. And looking at the source (which is also said to be fully-unit-tested) I'm even more impressed. Greg, you're damn hot crazy :-)) So yeah, I like the Games_Chess-backend-library. Did a cursory source- review. Just one suggestion: Would it be useful for getMessage to be moved to a separate language-file? Then you could come up with separate, additional files for supplying even more languages.Possibly - I was planning to simply integrate a new $_lang private variable, and a setLang() method, and put them right in there, or define methods like _getMessageEn(), _getMessageFr() and call them from getMessage(), but another file would be fine too. Of course, this is sort of a "when things stabilize" option currently, as I don't want to make people re-translate error messages if they change :). Greg