Re: DB_Nested 1.3 createRootNode problem
| From: | Greg Beaver | Date: | Mon, 27 Oct 2003 16:24:24 +0000 |
| Subject: | Re: DB_Nested 1.3 createRootNode problem | ||
| References: | 1 2 3 4 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-23041@lists.php.net to get a copy of this message | ||
Hi Daniel,
Regarding createLeftNode() to create a new top-level node, this makes perfect sense, but isn't intuitive, so can be fixed by documentation.
Daniel Khan wrote:
I would also strongly encourage you to drop the explicit specification of a mode in _raiseError(). You needn't change any of the calls to _raiseError() immediately, but simply pass in null instead of $mode to PEAR::raiseError(). I don't like seeing packages controlling error handling, that is an application realm. I know. I am running into BC breaks if I change too much of this for now. But I will have another look at the last versions to see what can be changed. The next major release will change this for sure.I don't see this as a BC break, _raiseError() is an internal private method - those can be changed willy-nilly as nobody can complain since they aren't supposed to depend on them anyways :) Greg