Re: cvs: pear(MAINT_0_10) /Net_NNTP/NNTP Protocol.php
| From: | Mirco 'meebey' Bauer | Date: | Wed, 19 Nov 2003 20:14:33 +0000 |
| Subject: | Re: cvs: pear(MAINT_0_10) /Net_NNTP/NNTP Protocol.php | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-23751@lists.php.net to get a copy of this message | ||
hiya Heino,
I found by accident some strange code in your commit.. (probably bug)
> - // Check if line terminates the textresponse
> - if ($line == ".\r\n") {
> - // return all previous lines
> - return $data;
> - break;
> + // Validate recieved line
> + if (false) {
> + // Lines should/may not be longer than 998+2 chars (RFC2822 2.3)
> + if (strlen($line) > 1000) {
> + return PEAR::throwError('Invalid line recieved!', null);
> + }
> }
>
there it is: "if (false)" I think you want to check false against some
value :)
Mirco