AW: [PEAR-DEV] Re: [PATCH] Fix WS and a Notice in XML_Beautifier
| From: | Stephan Schmidt | Date: | Fri, 21 Nov 2003 13:18:43 +0000 |
| Subject: | AW: [PEAR-DEV] Re: [PATCH] Fix WS and a Notice in XML_Beautifier | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-23793@lists.php.net to get a copy of this message | ||
Hi,
If you like, you could commit your patches for XML_Util and XML_Beautifier.
Changes seem to be fine.
Stephan
> -----Ursprüngliche Nachricht-----
> Von: Davey [mailto:davey@php.net]
> Gesendet: Freitag, 21. November 2003 08:18
> An: pear-dev@lists.php.net
> Betreff: [PEAR-DEV] Re: [PATCH] Fix WS and a Notice in XML_Beautifier
>
>
> Davey wrote:
>
> > Hey,
> >
> > Another patch from me[1]. Its two diffs in one file, the first
> (and much
> > larger) is a whitespace ONLY patch. The second removes a E_NOTICE thrown
> > when no children exist when dealing with CDATA or EMPTY elements. It
> > comes to mind that because they are CDATA or EMPTY elements they will
> > NEVER have a child element and so my code could be changed like this:
> >
> > From:
> > if (sizeof($struct["children"]) >= 1) {
> > $data = $struct["children"][0]["data"];
> > } else {
> > $data = '';
> > }
> >
> > To:
> >
> > $data = '';
> >
>
> Just updated the patch[1] to include another Notice eradication. The
> patch contains the WS fix as one diff, then the two notice fixes as one
> patch.
>
> - Davey
>
> [1]
> http://davey.is-a-geek.com/php-cvs/diffs/PEAR/XML_Beautifier.txt
>
> --
> PEAR Development Mailing List (http://pear.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>