Re: reviewd your commits on MDB

Hi Lukas, I don't see any problem in your diff. I'll make a test when you have committed it. FrontBase handles ports slightly different than other databases. If a database is given as an integer that indicates a port number and it uses that to connect to the server. It should be Ok the way it is now. - Frank > Hi Frank, > > I reviews your commits in order to port them to MDB 2.x > > I have one question plus a few minor fixes I did to my local copy which you > may want to review if you find the time. > > 1) question > I am not sure if the handling of the port is really correct: > $this->connection = @$function( > $port > 0 ? $port : $this->host, > $this->user, $this->password); > > 2) the fixes I made you will find in the attached txt file > > After I made the diff I noticed that my diff is not a unified diff. > Also I included simple whitespace fixes as well. > If this is a problem I can create a new diff. Just give a whistle! > > Regards, > Lukas Smith > smith@backendmedia.com > _______________________________ > BackendMedia > www.backendmedia.com > berlin@backendmedia.com > > Linn Zwoch Smith GbR > Pariser Str. 44 > D-10707 Berlin > > Tel +49 30 83 22 50 00 > Fax +49 30 83 22 50 07 > >