RE: [PEAR-DEV] DB_NestedSet not updating parent id properly
| From: | Andy Crain | Date: | Wed, 26 Nov 2003 17:34:52 +0000 |
| Subject: | RE: [PEAR-DEV] DB_NestedSet not updating parent id properly | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-23895@lists.php.net to get a copy of this message | ||
Thanks!
Happy to help out a great project. Let me know if you have any questions or
something comes up.
Andy
> > Daniel,
> > You're right, except that when using a method like moveTree(), it's not
> > possible to specify a node's values/payload, only node ids, and so it's
> not
> > possible to exclude the parent id. Still, it's possible to correctly
> update
> > the parent ids, without changing _requiredParams and causing a BC break,
> by
> > testing for $this->flparams['parent'] from inside _moveCleanup() and if
> so
> > then updating the parent id on each clone node.
> > Andy
>
> Yes - you are right.
> I didn't look close enough into the problem.
>
> Meanwhile I commited your patch and it looks good so far - I will add
> some tiny modifications and tests the next days.
>
> I will also have to find out why my testsuite didn't catch the query
> bugs you pointed out.
>
> You did a really great job!
>
> greetings
>
> --
> Daniel Khan
>
> --
> PEAR Development Mailing List (http://pear.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php