Re: Problems with PEAR::DB limitQuery

Hi! Jeroen Houben wrote:

In older versions the LIMIT #, # *was* correct. From the postgresql changelog @ http://developer.postgresql.org/~momjian/HISTORY.html (under migrating to 7.3) : Disable LIMIT #,# syntax; now only LIMIT # OFFSET # supported (Bruce) So the class should do a version check and then execute the proper code. HTH,

The class should NOT do any version check, as LIMIT # OFFSET # syntax is valid for all PostgreSQL versions, which is not true for LIMIT #,#. Martin is right.

I found with an aplication I started using the the limitQuery method has problems with PostgreSQL. Basically, in PostgreSQL (don't know hpow others do it) you do a: LIMIT count OFFSET start Where start and count are self explained. So, in DB/pgsql.php, this: // }}} // {{{ modifyLimitQuery() function modifyLimitQuery($query, $from, $count) {

       $query = $query . " LIMIT $count, $from";
       return $query;

} Should be changed to this: // }}} // {{{ modifyLimitQuery() function modifyLimitQuery($query, $from, $count) {

       $query = $query . " LIMIT $count OFFSET $from";
       return $query;

} Good luck!