Re: Pager_Sliding::getOffsetByageId()

On Thu, 11 Dec 2003 10:11:15 -0000, Richard Heyes wrote: > Hi Lorenzo, > Thanks for the quick response thank you for the report! > The fixed function works a treat. Nice work on the merge btw. > Richard Heyes tnx. I did my best :-) Best regards, Lorenzo > On Wed, 10 Dec 2003 14:39:20 -0000, Richard Heyes wrote: >> Hi Lorenzo, >> What's the deal with this method? In Pager it returned the >> offsets for the first and last pieces of data, whereas with >> Pager_Sliding it returns the first and last page numbers. Is this >> intended? If so then it breaks BC with Pager. > > Hi Richard, > > thanks for your note. The method in Pager_Sliding is just a big > mistake, while I wanted to provide such a method, it was certainly > not intended to override Pager's one. > Of course it does not affect Pager_Jumping, only _Sliding. I've > fixed the bug in CVS, and added a method called > "getPageRangeByPageId()" to fulfill the other purpose. > > Please give a try to current Pager CVS version, it > should work as expected, now (at least the testsuite > says so :-) > > If there aren't other issues, I'll roll out a new release soon. > > Best regards, > Lorenzo