Re: [Patch] Text_Password - improved pronounceability

Btw - i discussed this with someone a while ago, is this implemented already? I worked at support sometime ago, and most of the login-problems where becaus of automatically generated password with confusing characters, that can't be seperated with some fonts (for example 1 and l, 0 and O, and so on). When people receive an email with a password containing severeal of these characters he is confused... so there should be an option to eliminate these! bye, Stephan http://www.perl.com/CPAN-local/modules/by-module/WWW/WWW-Search-2.35.readmejackh@iol.ie wrote:

Hi there, This patch affects the pronounceability of passwords generated by the _createPronounceable() function, without any noticeable degradation in performance or any obfuscation of the code. Conceptually, there are three changes. 1 The main functional change is that the $c array of consonants and consonant soudns in replaced with a pair of arrays. $c1 which contains consonants and consonant sounds which are suitable for beginning a string. $cn is an array of consonants and consonant sounds which are more suited to the middle and and of strings. For example "rt" is not pronounceable at the start of a word, but is when preceded by a vowel sound. 2 The construction of _createPronounceable's returned value has also been modified to take advantage of the above. Instead of looping through pairs of (Random Consonant Sound, Random Vowel Sound), the returned pronounceable password is now constructed as: Initial Consonant Sound, followed by pairs of (Random Vowel Sound, Random Consonant Sound) 3. The contents of the vowel array have also been tweaked. The pronounceability of any string is subjective. I find that the strings produced by this patch are more pronounceable than those produced by the original. People from a different linguistic heritage may disagree. This is an area which I frequently find myself coming back to as generating random pronounceable strings efficiently is important for a project I work on. I will periodically attempt to improve this area of my local copy of the code, and would be happy to release those improvements to Pear, if approved. This is my first time submitting a Pear patch, so please forgive any glaring breaches of protocol. I have tried to follow the coding and submission guidelines on pear.php.net Best Reagrds, Jack Healy -------------------------------------------------------------------- mail2web - Check your email from the web at http://mail2web.com/ .