Re: Payment_paypalipn submission

On Sun, 14 Dec 2003 12:56:37 -0600 Jeremy Johnstone <jsjohnst@altdns.net> wrote: > Package Name: payment_paypalipn > Developer: Jeremy Johnstone > Site URL: http://www.scriptdevelopers.net > Download URL: > http://www.scriptdevelopers.net/dl.php?product=paypal_ipn > Description: > > A class which allows someone to implement PayPal IPN's payment system > on their site. This script handles the POST from PayPal and then > verifies it through their existing system. - The constructor should use an array to pass each possible argulent (and not only the protocol) - I like to use standard names for protocols, like https, ftps, http,... and not only s :) - ::error_out is kinda useless :). If someone would like to log the transactions, Log exists. - @get_magic_quotes_gpc(), '@' is ugly (line 45) - You may add htmlentities to both key and value while transforming the post variables (line 51) - @implode (line 55) , '@' is still ugly, a little check before the loop is far cleaner I like the idea of a Paypal function in PEAR and even more to have it using a common interface, as suggested Ian in their Payment_Process proposal. If you disagree to bundled it in a common payment package, it would be nice to have 2 different implementations, using HTTP_Client or CURL. And the name should be something like Payment_PaypalIPN or Payment_Paypal_IPN. Payment_Paypal_IPN only if more transactions system exist. > Notes: > I will be making changes to the script for it to better fit within > PEAR's CS. I wanted to get approval for the script before doing the > work(although it is simple to do). PayPal's own development department > suggested this script be added into PEAR so it would be available to a > larger audience, and thus is the reason for my request today. PEAR CS compliance is a requirement thanks for your proposal, pierre