Re: [Call for Votes] Payment_Process

From: Date: Wed, 17 Dec 2003 23:21:31 +0000
Subject: Re: [Call for Votes] Payment_Process
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-24522@lists.php.net to get a copy of this message
Ian Eure wrote:
I believe that all the issues raised by my RFC[1] and Proposal[2] have been addressed. Therefore, I'm requesting a call for votes for Payment_Process.
OK, Vote: *Conditional* +1 (see below) Review: cursory review of code Account: davey Comments: Why does this extend PEAR? Then you go onto call PEAR::isError, PEAR::raiseError statically. I think the extension of PEAR is unnecessary, a common mistake it seems. This generates lots of uneeded overhead. Full apidoc should be added. This is the *minimum* documentation I feel *any* code should have to be allowed into PEAR. Fix these and I will make it a proper +1 - Davey

« previous php.pear.dev (#24522) next »