Re: DB modifyQuery()
| From: | Bertrand Mansion | Date: | Sat, 03 Jan 2004 10:37:36 +0000 |
| Subject: | Re: DB modifyQuery() | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-24725@lists.php.net to get a copy of this message | ||
<smith@backendmedia.com> wrote :
> Hi,
>
> I was just looking at the modifyQuery method.
> It seems that its missing the "_" private prefix (in the sqlite driver its
> there but there are some issues with the phpdoc comments).
>
> Also it seems to me like it would make sense to only call the method in
> portability mode. Some implementations check for portability mode inside
> modifyQuery() and some don't. I think it would make more sense to check for
> portability mode inside the query method before evening calling this method
> (safes a method call). I guess if we are messing with that option we might
> as well cover all the bases while we are at it.
Good point.
Bertrand Mansion
Mamasam