Re: [Call for Votes v2] Payment_Process

From: Date: Mon, 05 Jan 2004 20:59:36 +0000
Subject: Re: [Call for Votes v2] Payment_Process
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-24784@lists.php.net to get a copy of this message
Ian, this looks nice. Only one nitpick: I think the constants are supposed to be named for the full package (i.e., PAYMENT_PROCESS_*, not just PROCESS_* ... "process" is generic enough to cause conflicts either now or later). Other than that: Account: pmjones Review: 10-minute source code review
Vote:    +1
-- Paul M. Jones pmjones@ciaweb.net Savant: the simple alternative to Smarty. http://phpsavant.com/

« previous php.pear.dev (#24784) next »