Re: Re: patch for Text/Wiki/rules/url.php
| From: | Jim Winstead | Date: | Wed, 07 Jan 2004 03:00:11 +0000 |
| Subject: | Re: Re: patch for Text/Wiki/rules/url.php | ||
| References: | 1 2 3 4 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-24841@lists.php.net to get a copy of this message | ||
On Tue, Jan 06, 2004 at 08:44:55PM -0600, Paul M Jones wrote:
> >i have a more general problem with the paragraph rule, but it may be
> >working as intended and that just differs from my intentions. ;)
>
> [you were expecting]
> > <p>This is the third paragraph.</p>
>
> [but instead get]
> > This is the third paragraph.
>
> I fear that it is the expected behavior for the regex. Not exactly
> intentional, but does work as programmed. ;-)
well, it wasn't just the third paragraph i was worried about -- the
first two were rather mangled, too.
the more i look, i think the real conflict is how i expect newlines to
be handled vs. stripping them and requiring \ continuation characters.
i'll just make my own paragraph rule and eliminate the tighten rule.
> For what it's worth, I am considering "forcing" a leading newline and
> trailing newline on the text to be parsed; that seems to fix all manner
> of errors at the end of the text. You may wish to try it and see how
> it works for you. "Tighten" ends up removing them nicely, and
> paragraphs come out right. Would you find that an adequate solution?
that would probably help in general. (it would have avoided the problem
i patched in the list rule.)
> Hey, when you discover the proper rule set, would you consider
> contributing them to Text_Wiki? I'd like to start collections of rule
> sets for specific Wiki implementations and distribute them as part of
> the Text_Wiki package.
sure. once i've got a set banged out and actually working. i'm sure
i'll have some other patches, too. ;)
> >with 8 new rules (and the above tweaks), it seems to be able to handle
> >all the pages i'm throwing at it, but i haven't really played with how
> >those new rules may interact with the existing ones.
>
> Yes, well, that's where the fun starts. ;-)
indeed. ;)
jim