Re: DB getRow() argument order

Daniel Convissor wrote:

Hi Folks:

But, in some long distant version of DB, the getRow() method (in DB/common.php) had the $params and $fetchmode arguments reversed. The current order was already in place when version 1.1 of the file was committed to the current repository location nearly two years ago on Jan 30 2002. I looked for earlier change information in php-src/pear but couldn't find common.php. This method has some convoluted compatibility checking which would be nice to avoid. Also, getting rid of this checknig would allow the method to behave like all the other get*() methods by allowing a scalar to be passed to $params. Chances are, it's safe to make this change, particularly if it's clearly noted in the changelog. Your thoughts, please?

Touchy subject. A BC break is a BC break, especially if it doesnt fix a bug this one is quite clear. The thing is just because the recommended way changed a while back doesnt mean that people actually changed their code. Noting this in the changelog is not going to help the people that just want the latest bug fixes and not the latest BC break. Therefore its actually a clear no. Eventually once we start a new major version for DB we can fix those until then all the convulted BC hacks need to stay in. regards, Lukas