Re: suggestions for DB class autoExecute() method
| From: | Daniel Convissor | Date: | Mon, 19 Jan 2004 03:57:12 +0000 |
| Subject: | Re: suggestions for DB class autoExecute() method | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-25145@lists.php.net to get a copy of this message | ||
Hi Jim:
On Sun, Jan 18, 2004 at 10:34:51PM -0500, Jim Keller wrote:
>
> 1. There doesn't appear to be any way to have "as is" values in auto insert
> /auto update statements, as buildManipSQL uses '?' as the placeholder
Good point. Put in a feature request for this via the bug system. Wow, I
just took a look at the code in buildManipSQL(). Performace could benefit
from a rewrite. I'll look into both of these issues a little later.
> 2. It may be advantageous to allow users to pass a $where string that
> includes the WHERE keyword, just for readability in their own code.
... snip ...
> 3. It might be easier for the user if you were add a simple method, perhaps
> autoUpdate(), that's just an alias to autoExecute with the $mode set to
> DB_AUTOQUERY_UPDATE by default.
Nice ideas, but they don't seem like they're worth the overhead.
> 4. In my own class, I was very determined not to allow update queries to
> execute without a where statement
I don't feel it's DB's job to babysit programmers.
Thanks for your insights,
--Dan
--
T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y
data intensive web and database programming
http://www.AnalysisAndSolutions.com/
4015 7th Ave #4, Brooklyn NY 11232 v: 718-854-0335 f: 718-854-0409