[PEPr] Comment on Mail::Imap
| From: | PEPr | Date: | Sun, 01 Feb 2004 10:51:31 +0000 |
| Subject: | [PEPr] Comment on Mail::Imap | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-25385@lists.php.net to get a copy of this message | ||
Bertrand Mansion (http://pear.php.net/user/mansion) has commented on the proposal for Mail::Imap.
Comment:
I don't like the class with your recent additions related to output (called "Bells and
Whistles" in your comments). Those methods are View related and output html. They don't
belong here and they just make the class more bloated.
Same thing for the forum stuff. Just get rid of it, if people want to have this feature, all they
need is the raw mail body and a static function to parse that content in the format they want.
Really this just adds bloat to a class that needs to be as light as possible.
Also, I don't see the point to call your methods imapSomething. Just get rid of the imap prefix
and we might be able to later have a Mail_POP3 class with the same API.
And again, you have instance vars called ccPersonal etc., which might not be set. Are you going to
try to match every possible header lines to instance vars ? That's the bad way. Just have a
header instance var (array) and fill it with clean header values. Then add a few accessor methods
for common header content that needs cleanup (ie. getTo(), getFrom(), getSubject()...).
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=17
--
Sent by PEPr, the automatic proposal system at http://pear.php.net