RE: [PEPr] +1 for Structures::DataGrid

> -----Original Message----- > From: PEPr [mailto:pear-sys@php.net] > Sent: Friday, March 05, 2004 9:09 AM > > Joe Stump (http://pear.php.net/user/jstump) has voted +1 on the > proposal for Structures::DataGrid. > > Proposal information: > http://pear.php.net/pepr/pepr-proposal-show.php?id=26 > Vote information: > > http://pear.php.net/pepr/pepr-vote-show.php?id=26&handle=jstump > > This vote is conditional. The condition is: > > 1.) Rename classes in source code to reflect package name change. > I am planning on doing this, just wanted to get some feedback about the name change > 2.) DataGrid::dump() should be either a.) renamed to reflect what > it does (debug) or b.) changed into a new renderer (debug) > Well, in my mind the dump method does that exactly, it offers a dump of the data in the datagrid. > 3.) It's not necessary to return $this from class constructors > (ie. HTML_DataGrid_Column). > > 4.) I'd set autoFill in Column to a default of some sort ('n/a' > or simply ' ') so HTML cells don't format incorrectly with no data. > This is automatically handled by HTML_Table, so it is unecessary for the DataGrid to handle this. > 5.) In setRenderer you should check the include with > if(include()) and return a PEAR_Error if I supplied the function > with 'foo' since the renderer does not exist (looks like the code > to do this is there, but commented out). > Yeah, this method needs more cleaning ... > I, personally, can't wait for this package to come out (I've been > too lazy to write my own for quite some time). Thanks! Great, well hopefully you will be able to contribute some of your ideas to the package! THanks for the comments, Andrew