[PEPr] Comment on PEAR::Error_Stack
| From: | PEPr | Date: | Tue, 09 Mar 2004 20:55:47 +0000 |
| Subject: | [PEPr] Comment on PEAR::Error_Stack | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-26236@lists.php.net to get a copy of this message | ||
Laurent Laville (http://pear.php.net/user/farell) has commented on the proposal for
PEAR::Error_Stack.
Comment:
Hello Greg,
You already know that i like this package and its features, but i think you could optimize a bit the
constructor class.
Use the setMessageCallback() and setContextCallback() rather than same lines of code.
And of course change lines 307, 354 (null test) by false test.
All the best for this proposal.
Laurent Laville
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=30
--
Sent by PEPr, the automatic proposal system at http://pear.php.net