[PEPr] Comment on File Formats::File_Gettext

From: Date: Sat, 13 Mar 2004 10:33:33 +0000
Subject: [PEPr] Comment on File Formats::File_Gettext
Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-26375@lists.php.net to get a copy of this message
Lorenzo Alberton (http://pear.php.net/user/quipo) has commented on the proposal for File Formats::File_Gettext. Comment: I checked cvs version (1.4) and runs fine. Just a few more pedantic notes: - require_once is a statement, not a function, so the parenthesis are not needed: require_once 'myfile.php'; - toArray() and fromArray() should not be needed in MO/PO.php since they're inherited by the extended class. - in File_Gettext::fromArray(), the order of array_key_exists() parameters is switched - in File_Gettext::poFile2moFile(), $mofile should be created if not exists yet, instead of raising an error: if (!is_file($mofile)) { touch($mofile); } Apart for that, I'm really happy with it! Lorenzo Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=33 -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#26375) next »