[PEPr] Comment on Networking::Net_GameServerQuery
| From: | PEPr | Date: | Wed, 17 Mar 2004 11:14:04 +0000 |
| Subject: | [PEPr] Comment on Networking::Net_GameServerQuery | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-26498@lists.php.net to get a copy of this message | ||
Stefan Neufeind (http://pear.php.net/user/neufeind) has commented on the proposal for
Networking::Net_GameServerQuery.
Comment:
Looks nice from what I saw. Had a look at examples and code.
You're using php5-syntax. Though this is generally good I personally would favor to be able to
run it with php4.x for a while longer, also. I mean, the private-declarations could maybe be avoided
and noted in the phpdoc-comments? Haven't tried, but if there is nothing else that won't
work with 4.x imho it might be good to stay backward-compatible.
Other packages which have decided to move on to an php5-only already are afaik always having a still
existant 4.x-branch.
Could it be that the "Day of Defeat"-example does not always work? Several times I got
"Query took 1000.89ms" or similar instead of the answer. Maybe timing-problems?
And please do some fixing to the phpdoc-comments. E.g. for variables you need @var, the whole
package should also have a doc-blook, include license at the top, I'd prefer to see the author
listed once - not for every function and similar.
The package is still quite small. Does this result from the fact that all servers react quite
similar? Maybe more games could be added? And maybe you could try to provide some commonly named and
format, parsed information fields for all game-servers as well.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=34
--
Sent by PEPr, the automatic proposal system at http://pear.php.net