Re: [PEPr] Comment on File Formats::File_Fstab

On 3 Apr 2004 at 11:57, Ian Eure wrote: > On Saturday 03 April 2004 02:49 am, PEPr wrote: > > Stefan Neufeind (http://pear.php.net/user/neufeind) has commented on the > > proposal for File Formats::File_Fstab. > > > > Comment: > > > > I generally like the idea. Not that I have much use for it at the moment, > > but maybe others will? However, I wonder if settings like the filesystem > > etc. should better be done via function-calls as they might allow optional > > checking for validity. E.g. the filesystem might *optionally* be checked > > against a list found in a file, by standard maybe /proc/filesystems. Also > > blockdevs might optionally be checked if they exist etc. Optional because > > maybe you edit the fstab for a machine different than yours which might > > support different filesystems or so. > > > A nice idea, but a bit beyond the scope of what I want to do with File_Fstab. > I'd be happy to add set/get functions in _Entry, though, so a descendent > class could add this functionality. Well, but if you're going to implement get-/set-methods, what's the big deal of adding the optional verification? Imho this is what it would need to make the package "complete". Otherwise I might as well do the text-manipulations (adding a mountpoint "by hand", deleting a line from the file etc.) even without the class. I thought you wanted to make it more easy to handle the file ... and I think if the package makes it into PEAR it should be "complete" (in a sense), so we won't end up in a situation like "well, somebody else might implement that in his app" or so. Or did I get you wrong? Regards, Stefan