[PEPr] Comment on RFC::Package naming, file naming and directory structure RFC
| From: | PEPr | Date: | Tue, 20 Apr 2004 00:56:44 +0000 |
| Subject: | [PEPr] Comment on RFC::Package naming, file naming and directory structure RFC | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-28096@lists.php.net to get a copy of this message | ||
Alan Knowles (http://pear.php.net/user/alan_k) has commented on the proposal for RFC::Package
naming, file naming and directory structure RFC.
Comment:
looking pretty good.
couple of points:
- tests/docs/etc. should never be within the include path, it makes accidental includes possible,
and is a slight security concern.
- On the 1file = 1class issue - the only exception to this would be if performance was an absolute
necesity. caches like APC can make this a mute point however.
may be worth noting that having a factory/base/interface class, rather than seperate files/classes
for these is more effecient in PHP..
- you should really copy/paste all the comments made, (or a summary of them) - and indicate how they
have been address.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=55
--
Sent by PEPr, the automatic proposal system at http://pear.php.net