[PEPr] Comment on Internationalisation::Locale_Maketext

Alan Knowles (http://pear.php.net/user/alan_k) has commented on the proposal for Internationalisation::Locale_Maketext. Comment: quick review: factory() is a bit odd - if you want to use it with your own extended class - then you may as well not use factory.. - it also doesnt do the include to load the class.. the coding standards state that # is discouraged as a comment style.. just because gettext is aliased to _, I'm not sure its a very good idea to impelement it as a class method. all methods aaaa_bbbb should be aaaaBbbbb do not use short if statements eg. if ($a) dosomething(); you may want to look at: switch (true) case ($m == '' || $m == '['): ... to tidy up the big if/elseif/elseif/elseif..... Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=44 -- Sent by PEPr, the automatic proposal system at http://pear.php.net