[PEPr] Comment on Networking::Net_SMS
| From: | PEPr | Date: | Fri, 23 Apr 2004 08:06:01 +0000 |
| Subject: | [PEPr] Comment on Networking::Net_SMS | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-28278@lists.php.net to get a copy of this message | ||
Alan Knowles (http://pear.php.net/user/alan_k) has commented on the proposal for
Networking::Net_SMS.
Comment:
Thanks for the link
In general looks really good. - a couple of minor things.
* gettext _() , I'm not sure it's a good idea to force a requirement on gettext, I dont
have any great ideas on alternatives though..
* getGatewayInfo/getGatewayParams = all look like convience methods, I'm not sure they add much
value, other than making the API bigger.. (meaning more to document, more to read..)
* there's a few typos on the include/require - it should be 'Net/SMS/'.$class...
* Im not sure if the drivers should be (as in _ == / )
Net_SMS_ClickaTelViaSmtp
Net_SMS_ClickaTelViaHttp
or is it worth
- dropping the transport method??
- having Net_SMS_Http_ClickaTel.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=59
--
Sent by PEPr, the automatic proposal system at http://pear.php.net