Re: [PEPr] +1 for Text::Text_Highlighter
| From: | David Grant | Date: | Thu, 20 May 2004 14:48:01 +0000 |
| Subject: | Re: [PEPr] +1 for Text::Text_Highlighter | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-29449@lists.php.net to get a copy of this message | ||
PEPr wrote:
David Grant (http://pear.php.net/user/djg) has voted +1 on the proposal for Text::Text_Highlighter.
Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=72 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=72&handle=djgErm, I just noticed something in Highlighter.php. On line 168, you're using single quotes for the string, which means variable substitution won't happen. This means I get the following misleading error string: "Highlighter for ${lang} not found" Instead of (e.g.) "Highlighter for FOOBAR not found" To reproduce: require_once("Text/Highlighter.php"); var_dump(Highlighter::factory("FOOBAR")); Regards, David