[PEPr] +1 for Text::Figlet
| From: | PEPr | Date: | Sat, 22 May 2004 10:10:16 +0000 |
| Subject: | [PEPr] +1 for Text::Figlet | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-29548@lists.php.net to get a copy of this message | ||
Arnaud Limbourg (http://pear.php.net/user/arnaud) has voted +1 on the proposal for Text::Figlet.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=73
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=73&handle=arnaud
This vote is conditional. The condition is:
/**
* Text_Figlet constructor. Does nothing right now, just calls
* parent constuctor.
*
* @access public
*/
function Text_Figlet()
{
return true;
}
mm, that code is not needed :)
Same as Jan, issues like var $Font; when it should be var $font; and if without curly braces used.
Other than that it's good :)
--
Sent by PEPr, the automatic proposal system at http://pear.php.net