Re: [PEPr] +1 for System::System_Mount

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Tuesday 25 May 2004 11:37 am, PEPr wrote: > Klaus Guenther (http://pear.php.net/user/thesaur) has voted +1 on the > proposal for System::System_Mount. > > Proposal information: > http://pear.php.net/pepr/pepr-proposal-show.php?id=67 > Vote information: > > http://pear.php.net/pepr/pepr-vote-show.php?id=67&handle=thesaur > > This vote is conditional. The condition is: > > As Martin said, a CS issue to clean up... > It's fixed in my local CVS. > Also, though I'm not religious about it, shouldn't you put > System_Mount_Entry into a separate file (System/Mount/Entry.php)? It's not > like its going to slow this down that much. > I could, but I didn't think there was much point; the System_Mount class is only 54 lines long, docblocks and all. It didn't seem worth it to split up, but I have no problem doing that if the general concensus is that it's the correct thing to do. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFAs7bCxuUdPD6j2IMRAu2QAJ9XGgl188rOUZ+dOzqidTIiJzAoPwCgj+yl LmRz3c7x2y1f5qu77Im8bM0= =pTTR -----END PGP SIGNATURE-----