[PEPr] +1 for Text::Figlet
| From: | PEPr | Date: | Fri, 28 May 2004 22:28:37 +0000 |
| Subject: | [PEPr] +1 for Text::Figlet | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-29778@lists.php.net to get a copy of this message | ||
Daniel Convissor (http://pear.php.net/user/danielc) has voted +1 on the proposal for Text::Figlet.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=73
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=73&handle=danielc
This vote is conditional. The condition is:
Cute tool.
Here are some additional minor coding standards fixes, please:
1) Put the ":" in the $Id:$ tag.
2) Private property names (meaning the var's) need to be preceeded with an underscore (example:
"var $_foo;")
3) echoLine() is a better OO name than lineEcho(). Action first, subject second.
4) Re the docblocks: the indenting on the ones above the vars is good. The ones above the methods
need to have the additional rows nudged in one space so the subsequent asterisks line up with the
first asterisk. Also, it'd be nice to remove the space between the comments and the items they
are commenting on. All this is as per JavaDoc standards and now coverd in the coding standards
sample file:
http://pear.php.net/manual/en/standards.sample.php
--
Sent by PEPr, the automatic proposal system at http://pear.php.net