Re: [PEPr] Comment on PEAR::NameScheme
| From: | Andrey Demenev | Date: | Sun, 06 Jun 2004 14:08:47 +0000 |
| Subject: | Re: [PEPr] Comment on PEAR::NameScheme | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-30034@lists.php.net to get a copy of this message | ||
Pepr wrote:
Dmitry Koteroff (http://pear.php.net/user/koteroff) has commented on the proposal for PEAR::NameScheme. Comment: Andrey, if you call include_once "system.php" in your program, you also load ./system.php, not /usr/local/php/System.php. And even more — your code is not windows-compatible at all (because Windows loads files in case-insensitive mode) and bad because of that.I can always do include_once "./system.php". This was just an example, there may be more complex cases.
About coding standarts — first let's vote, and in the case of positive mark I'll convert the package.I am talking not about _coding_ standards (although they are important too), but about _naming_ standards you rely on (like class OLE must reside in OLE.php), which are not respected by all packages (actally it is in OLE/OLE.php) As I already said, I personally don't see any use in this package. Another note: when I run this script <?php require_once 'NameScheme.php'; echo PEAR_NameScheme::path2name('c:\php4\pear\System.php'); ?> I get this Warning: Unknown modifier '^' in c:\php4\pear\PEAR\NameScheme.php on line 55 c:_php4_pear_system
Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=82-- Andrey Demenev aka Blindman demenev@on-line.jar.ru