[PEPr] Comment on File Formats::MP3_Playlist
| From: | PEPr | Date: | Thu, 10 Jun 2004 23:55:24 +0000 |
| Subject: | [PEPr] Comment on File Formats::MP3_Playlist | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-30456@lists.php.net to get a copy of this message | ||
David Costa (http://pear.php.net/user/gurugeek) has commented on the proposal for File
Formats::MP3_Playlist.
Comment:
Hello Daniel,
thanks for your comments:
"I'm looking at http://dotgeek.org/mp3_playlist/source.php?src=0.
How about cleaning up the code to meet PEAR coding standards?"
>> by all means you are right and I will fix these issues as soon as possible
"
For example:
* The horizontal and vertical spacing of your docblocks.
* General horizontal and vertical spacing of the code in general.
Specific examples......"
I will do it tomorrow, thanks again for spotting this formatting issue.
"Much of this could be due to the mixed use of tabs and spaces. Please use spaces."
This is not my case I do use set expandtab on my config which means that each time I press tab only
spaces are included.
"For an example of clean, standard docblocks, please see
http://pear.php.net/manual/en/standards.sample.php"
Thanks. Beside the formatting problem (which will be fixed) let me know if you have any other
comment or idea.
Cheers
David Costa
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=87
--
Sent by PEPr, the automatic proposal system at http://pear.php.net