[PEPr] Comment on Images::Image_CAPTCHA
| From: | PEPr | Date: | Fri, 11 Jun 2004 12:33:35 +0000 |
| Subject: | [PEPr] Comment on Images::Image_CAPTCHA | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-30488@lists.php.net to get a copy of this message | ||
Martin Jansen (http://pear.php.net/user/mj) has commented on the proposal for Images::Image_CAPTCHA.
Comment:
A few points:
- You are using var_dump() at some point in the code, which is probably not desired.
- Can you replace NULL with null?
- The comment
/**
* Image_CAPTCHA - see above
*
* see above
*
* @package Image_Text
*/
is misleading, because in the API documentation there may be no text "above", because the
blocks are split up into multiple files.
- Inside a for-loop, you do not make use of the 4-spaces indentation.
Apart from that the code seems to be fine.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=80
--
Sent by PEPr, the automatic proposal system at http://pear.php.net