Re: Changes to File/Passwd.php

Go for it On Thu, 22 Nov 2001, Martin Jansen wrote: > Rasmus, > > I would like to commit the following changes to php4/pear/File/Passwd.php: > > Index: Passwd.php > =================================================================== > RCS file: /repository/php4/pear/File/Passwd.php,v > retrieving revision 1.4 > diff -u -r1.4 Passwd.php > --- Passwd.php 13 Jul 2001 17:56:50 -0000 1.4 > +++ Passwd.php 22 Nov 2001 14:52:16 -0000 > @@ -88,8 +88,8 @@ > $this->lockfile = $lockfile ; > } > > - $this->fplock = fopen($this->lockfile, 'w'); > if($lock) { > + $this->fplock = fopen($this->lockfile, 'w'); > flock($this->fplock, LOCK_EX); > $this->locked = true; > } > @@ -102,7 +102,7 @@ > $line = fgets($fp, 128); > list($user,$pass,$cvsuser) = explode(':',$line); > if(strlen($user)) { > - $this->users[$user] = $pass; > + $this->users[$user] = trim($pass); > $this->cvs[$user] = trim($cvsuser); > } > } > > > This patch is necessary in order to make a file-based storage > container for PEAR::Auth work (written by Stefan Ekman <stekman@sedata.org>). > I don't think that this patch will break anything, no? > > Please let me know if I can commit or not. > > - Martin > >