[PEPr] +1 for Networking::Net_HL7
| From: | PEPr | Date: | Fri, 02 Jul 2004 09:37:07 +0000 |
| Subject: | [PEPr] +1 for Networking::Net_HL7 | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-31484@lists.php.net to get a copy of this message | ||
Jan Schneider (http://pear.php.net/user/yunosh) has voted +1 on the proposal for
Networking::Net_HL7.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=92
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=92&handle=Yunosh
This vote is conditional. The condition is:
I should have reviewed the code in the comment phase, but anyway:
1) There are still some coding style issues, e.g. indention should be four spaces, no space after
not (!) operator.
2) The file HL7.php doesn't make any sense to me. If the values you set there are really
configurable, they should be passed as parameters to the according class constructors. If not, they
should be defined as constants. As the file doesn't contain any code, only variable definition,
it should be ditched completely. Even better: define a Net_HL7 class there to retrieve objects
defined by your package.
3) There are two empty classed that don't make any sense to me: Net_HL7_Request and
Net_HL7_Response
--
Sent by PEPr, the automatic proposal system at http://pear.php.net